build(deps-dev): bump sinon from 18.0.1 to 22.0.0#3149
Merged
Conversation
Bumps [sinon](https://github.com/sinonjs/sinon) from 18.0.1 to 22.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v18.0.1...v22.0.0) --- updated-dependencies: - dependency-name: sinon dependency-version: 22.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades sinon to version 22.0.0 and its associated types to 21.0.1. As part of this upgrade, several unit tests in api-request.spec.ts and jwt.spec.ts were updated to use the modern object-based configuration for sinon.useFakeTimers. The reviewer suggested further hardening these test configurations by adding the shouldClearNativeTimers: true option to ensure native timers are properly cleared and to prevent potential test leaks.
lahirumaramba
force-pushed
the
lm-bump-sinon
branch
from
a64794a to
bb0ee27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
@types/sinonto21.0.1and fix fake timer test leaks